Feature/gridedit 502 ridge refinement #235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only commited to pass between computers
To pass to other computer
…unassigned variable in Eigen library
…b.com/Deltares/MeshKernel into feature/GRIDEDIT-502_ridge_refinement
Compute hessian as in the fortran code
correct distance calculation in face edges use eigenvalue as sample value
…2_ridge_refinement
BillSenior
commented
Nov 13, 2023
Comment on lines
334
to
339
| { | ||
| std::vector<Sample> result = rawSamplePoints; | ||
|
|
||
| Hessian hessian(2, numY, numX); | ||
| PrepareSampleForHessian(rawSamplePoints, projection, numberOfSmoothingIterations, hessian); | ||
|
|
There was a problem hiding this comment.
Should there be a check that numX * numY == rawSamplePoints.size
There was a problem hiding this comment.
I have added this
…ompilation error in teamcity for use of Eigen libraru
…Eigen library under macos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.